feat(container-indicator): add live performance, configuration, and terminal access - #511

@ggbond268 PTAL

Thanks for adding these improvements! I reviewed 9d396cb2 and found two issues I recommend fixing before merging:

1. Terminal launches can block interaction with the whole app. AppleScript execution and waiting for the external process currently happen synchronously on the main thread. A slow launch can delay input throughout MacTools, including other plugins. Please run the launch asynchronously with a timeout, and update the UI on the main thread when it finishes.

2. The detail window can show stale readings as live data. When a stats read fails, it keeps the previous numbers and charts, but the error is only shown in the main panel. Please also show the failure and the last successful sample time in the detail window, clearly marking retained data as out of date.

Thanks again! These changes would make the new features more reliable.

Thanks for the review — both issues are fixed in a472fbb.

1. Terminal launch no longer blocks the app. ContainerTerminalLaunching.launch is now async. The controller starts it from a main-actor task and only publishes the error when it finishes, so input in other plugins stays responsive. The default launcher runs /usr/bin/open and NSAppleScript on background queues and resumes after a 10-second timeout (terminating a still-running open process), so a stalled terminal cannot leave the action pending forever.
2. Stale readings are marked in the detail window. When statsFailure is set, the live section now shows an orange banner with the failure message and the last successful sample time; the retained cards and charts stay visible but are explicitly labeled as out of date. The retained sample keeps its original sampledAt, covered by a test.

make test TEST_FILTER=ContainerIndicatorPluginTests — 44 tests passed.

Thanks for the update! I rechecked a472fbbe and confirmed that terminal launches no longer block app interaction. Two remaining cases still need a fix:

1. The AppleScript timeout does not stop the launch. After 10 seconds, the caller reports failure, but the script keeps running. A slow launch may therefore complete after the error, and retrying could open duplicate tabs. Please run the script in a cancellable subprocess, such as osascript, and terminate and clean it up on timeout.

2. Service-check failures can hide the stale-data warning. The detail window only checks statsFailure. If the service-status check fails, old readings remain visible while that warning disappears. Please also handle service-check failures in the detail window, keeping retained data marked as out of date with the last successful sample time until fresh data is available.

The 44 plugin tests pass, and I reproduced these cases with isolated diagnostics. Thanks again for the improvements!

Both remaining cases are addressed in d33e6ac.

1. Timed-out AppleScript is now stopped. The script runs as an /usr/bin/osascript -e subprocess through the same timeout runner as /usr/bin/open. On timeout the process is terminated, then force-killed after two seconds if it ignores SIGTERM, so a reported failure cannot be followed by a late tab or a duplicate on retry. A new test verifies a hanging helper returns at the timeout instead of the helper's full runtime.
2. Service-check failures keep the stale warning. The detail window now reads retainedDataWarning, which falls back to an inconclusive service check (status == .unknown) in addition to statsFailure. Retained cards and charts stay labeled out of date with the original sample time until a refresh succeeds. Added coverage for the inconclusive service-status path.

make test TEST_FILTER=ContainerIndicatorPluginTests — 46 tests passed.